| Age | Commit message (Collapse) | Author |
|
|
|
This is a hypothetical fix, since the condition `count == 0` may not
be true although `doit` has been allocated. In practice this should
not be possible since the same loop is executed twice in lines 463++
and 471++. But anyway, here it is...
|
|
Signed-off-by: Albrecht Schlosser <albrechts.fltk@online.de>
|
|
Some of the previous constness changes turned out to be incomplete,
others had to be reverted because some other driver methods could
not be made 'const' - particularly those calling open_display() to
get the requested information.
|
|
As requested by issue #181:
"Fl_Screen_Driver.H non-const functions should be const"
Not all methods could be made 'const' because some screen related
methods call init() internally.
|
|
|
|
src/Fl_Native_File_Chooser_WIN32.cxx:190:10:
warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound
depends on the length of the source argument [-Wstringop-overflow=]
190 | strncpy(wp2, string, n);
| ~~~~~~~^~~~~~~~~~~~~~~~
Although there was no real problem with the code (the allocated buffer
was large enough), the code was questionable and there was redundant
code that could be simplified.
|
|
|
|
|
|
This fixes this issue mentioned in fltk.general :
https://www.fltk.org/newsgroups.php?s40623+gfltk.general+v40638+T
|
|
|
|
Use correct conversions to Windows "wide character" encoding and
use the appropriate wide character functions.
|
|
Pre-clip coordinates to 16-bit range before using X11 clipping
functions because X11 supports only 16-bit int's.
|
|
|
|
This is a convenience method that does range checking (index n),
removes the child given by index n from the group and deletes it.
|
|
- disable warning C4244 (conversion / data loss)
- restore #pragma warning after nanosvg includes
|
|
Actually we don't know about some newer MSVC versions, but current
version MSVC 2019 works fine w/o defining round(). If other MSVC
versions need this as well we can change the version test or add
a compiler feature test to CMake (configure not required).
|
|
|
|
Compiling drivers/Posix/Fl_Posix_System_Driver.cxx...
drivers/Posix/Fl_Posix_System_Driver.cxx:176:14: warning: unused function 'quadruple_dlopen' [-Wunused-function]
|
|
|
|
- fix issue as proposed
- fix more potential access to uninitialized data issues
- document Fl_Shared_Image::add_handler()
- document typedef Fl_Shared_Image::Fl_Shared_Handler()
|
|
The font size is set to the value necessary for the GL scene before
computing the string width.
Virtual Fl_Gl_Window_Driver::effective_size() becomes unnecessary.
|
|
Fix sending bogus events if CONSOLIDATE_MOTION is on.
|
|
|
|
|
|
|
|
Fix copy paste error.
|
|
... as requested in this comment:
https://github.com/fltk/fltk/issues/211#issuecomment-814235771
|
|
PR #203 "Multithread fix for PNG loading" includes a suggested fix
that moves the variable fp to the Fl_PNG_Image structure.
This commit fixes the threading issue by allocating the variable fp
with new, avoiding the [-Wclobbered] warning w/o using a static var.
The same issue is now also fixed in Fl_JPEG_Image.
|
|
Thanks to K.R. for the fix.
|
|
|
|
Fl_Posix_System_Driver::probe_for_GTK()
|
|
|
|
Similarly move dlopen_or_dlsym().
This move is because GTK is not X11-specific.
|
|
|
|
|
|
Albrecht caught a problem with my strncat use (see comments for 12d8da9c).
I noticed we have fl_strlcpy() and fl_strlcat() which is what was really
needed here.
|
|
|
|
As per erco's comments on fltk.coredev, Mar 21 2021
in thread Subject: Re: 1.4 build failing on OSX for me
|
|
Cairo is not used in this file, math.h is not necessary, and stdio.h
is only required if USE_PANGO is false.
|
|
FL_BLACK changed to FL_FOREGROUND_COLOR as per docs.
|
|
This file was included (in math.h or elsewhere) on Linux and latest
macOS versions but maybe not in earlier macOS versions or with other
configuration options.
|
|
- convert filename from UTF-8 to "Windows wide chars"
- use GetFileAttributesW() instead of _stat()
|
|
Add includes of system headers in the implementation files
where necessary.
|
|
Applied vsnprintf_v2.patch from STR#3413 which documents
the previously undocumented function, so that it shows up
here in the doxygen docs:
Files -> File List -> vsnprintf.c -> fl_vsnprintf()
This commit does not solve STR #3413, just adds the recommended documentation
for fl_vsnprintf(). Other functions in src/vsnprintf.c could use docs too.
See the bottom of comment #5 in the STR for recommendations to fully solve.
|
|
|
|
This fixes the inconsistency created by the possibility to change img->w() and img->h()
values. The fix is to use img->data_w() and img->data_h() that have constant values.
|
|
|
|
That class is extracted from inside Fl_PostScript_Graphics_Driver and might
become handy in the future.
|
|
USE_PANGO
|