From 220dd47bea588e65416faa2a51663304f8d0a8bc Mon Sep 17 00:00:00 2001
From: ManoloFLTK <41016272+ManoloFLTK@users.noreply.github.com>
Date: Fri, 22 Sep 2023 11:51:24 +0200
Subject: Increase reuse of mmap'ed data by FLTK Wayland buffer factory
---
documentation/src/wayland.dox | 61 +++++++++++++------
src/drivers/Wayland/Fl_Wayland_Graphics_Driver.H | 10 ++--
src/drivers/Wayland/Fl_Wayland_Graphics_Driver.cxx | 70 ++++++++++++++++------
3 files changed, 101 insertions(+), 40 deletions(-)
diff --git a/documentation/src/wayland.dox b/documentation/src/wayland.dox
index d01190ad9..7431e8d5f 100644
--- a/documentation/src/wayland.dox
+++ b/documentation/src/wayland.dox
@@ -632,6 +632,23 @@ a new buffer. When the compositor is not ready, the app does not block but conti
computing and drawing in memory but not on display more lines of the desired Mandelbrot
graph.
+Wayland buffer deletion
+Each \ref wld_buffer record contains boolean member \c in_use which is set to \c true
+just before the buffer gets committed, and boolean member \c released which
+is set to \c true when FLTK no longer needs the buffer and calls
+\c Fl_Wayland_Graphics_Driver::buffer_release().
+FLTK's buffer-creating function, \c Fl_Wayland_Graphics_Driver::create_shm_buffer(),
+attaches a 1-member listener to each buffer which Wayland calls after a commit
+operation to indicate the client is allowed to re-use the buffer.
+This listener's member function, \c buffer_release_listener(),
+turns to false member \c in_use of the buffer's \ref wld_buffer record.
+Since the two events 'FLTK no longer needs the buffer' and
+'the client is allowed to re-use the buffer' can arrive in
+any order, FLTK deletes the struct wl_buffer object by running
+\c do_buffer_release() only after both events happened, that is, when \c in_use is
+\c false and \c released is \c true. That's why function \c do_buffer_release()
+is called by both functions \c Fl_Wayland_Graphics_Driver::buffer_release()
+and \c buffer_release_listener().
\section wayland-buffer-factory Buffer factories
@@ -680,18 +697,26 @@ gives the offset within the current pool's mmap'ed memory available for a new \c
Macro \c wl_container_of() gives the address of a record belonging to a linked list of
records of the same type.
-A window's \c wl_buffer is re-used each time the window gets redrawn, and is destroyed by
-function \c Fl_Wayland_Graphics_Driver::buffer_release() when \c Fl_Window::hide() runs or
-the window is resized. Function \c Fl_Wayland_Graphics_Driver::buffer_release() destroys the
-\c wl_buffer with \c wl_buffer_destroy() and removes the corresponding
+A window's \c wl_buffer is re-filled by graphics data and committed each time
+the window gets redrawn, and is set to be destroyed by function
+\c Fl_Wayland_Graphics_Driver::buffer_release() when \c Fl_Window::hide() runs or
+the window is resized. When the \c wl_buffer is no longer in use, function
+\c do_buffer_release() gets called as explained above. It destroys the
+\c wl_buffer with \c wl_buffer_destroy(), and removes the corresponding
\c Fl_Wayland_Graphics_Driver::wld_buffer record from the linked list of buffers from the same \c wl_shm_pool.
Since new \c Fl_Wayland_Graphics_Driver::wld_buffer records are added at the head of the linked list, and since
the record at the head of this list is used to compute the offset within the pool's mmap'ed
memory available for a new \c wl_buffer, destruction of the last created \c wl_buffer
allows to re-use the destroyed buffer's pool's memory for a new \c wl_buffer.
-When the linked list results empty, the \c wl_shm_pool is destroyed by
-\c wl_shm_pool_destroy(), the pool's mmap'ed memory is munmap'ed, and the pool's associated
-struct wld_shm_pool_data is freed.
+
+When function \c do_buffer_release() finds the list of buffers from a given pool empty,
+two situations can occur. 1) This pool is the current pool. Its mmap'ed memory will be
+re-used from offset 0 to create future \c wl_buffer objects. 2) This pool is not
+current. It gets destroyed with \c wl_shm_pool_destroy(), the pool's mmap'ed memory
+is munmap'ed, and the pool's associated struct wld_shm_pool_data is freed.
+In situation 1) above, the next \c wl_buffer to be created can need more memory than
+the current pool's memory size. If so, the current pool gets destroyed and replaced
+by a new, larger pool.
If the sum of \c chunk_offset plus the buffer size is larger than the current pool's size
when function \c create_shm_buffer() is called, \c chunk_offset is reset
@@ -973,8 +998,8 @@ replacing it with the text that will stay in the document. FLTK underlines marke
to distinguish it from regular text.
Functions \c text_input_delete_surrounding_text() and \c text_input_done() have
-no effect at present, without this preventing input methods that have been tested with FLTK to work
-satisfactorily.
+no effect at present, without this preventing input methods that have been tested
+with FLTK from working satisfactorily.
It's necessary to inform text input methods of the current location of the insertion point in the
active surface. This information allows them to map their auxiliary windows next to the insertion
@@ -1188,17 +1213,17 @@ One such record is also embedded inside each
struct Fl_Wayland_Graphics_Driver::draw_buffer {
- size_t data_size; // of wl_buffer and buffer, in bytes
- int stride; // bytes per line
- int width; // in pixels
unsigned char *buffer; // address of the beginning of the Cairo image surface's byte array
cairo_t *cairo_; // used when drawing to the Cairo image surface
+ size_t data_size; // of buffer and wl_buffer, in bytes
+ int stride; // bytes per line
+ int width; // in pixels
};
FLTK gives offscreen buffers the platform-dependent type \c Fl_Offscreen which is
in fact member \c cairo_ of struct Fl_Wayland_Graphics_Driver::draw_buffer.
-Thus, a variable with type \c Fl_Offscreen needs be casted to type \c cairo_t*.
-
Static member function struct draw_buffer *offscreen_buffer(Fl_Offscreen)
+Thus, a variable with type \c Fl_Offscreen needs be cast to type \c cairo_t*.
+Static member function struct draw_buffer *offscreen_buffer(Fl_Offscreen)
of class \c Fl_Wayland_Graphics_Driver returns the \c draw_buffer record corresponding
to an \c Fl_Offscreen value.
@@ -1211,12 +1236,14 @@ text is dragged.
struct Fl_Wayland_Graphics_Driver::wld_buffer {
struct draw_buffer draw_buffer; // see \ref draw_buffer
+ struct wl_list link; // links all buffers from the same wl_shm_pool
struct wl_buffer *wl_buffer; // the Wayland buffer
void *data; // address of the beginning of the Wayland buffer's byte array
- struct wl_callback *cb; // non-NULL while Wayland buffer is being committed
- bool draw_buffer_needs_commit; // true when draw_buffer has been modified but not yet committed
+ struct wl_callback *cb; // non-NULL until Wayland can process new buffer commit
struct wl_shm_pool *shm_pool; // pter to wl_shm_pool from which this wl_buffer comes
- struct wl_list link; // links all buffers from the same wl_shm_pool
+ bool draw_buffer_needs_commit; // true when draw_buffer has been modified but not yet committed
+ bool in_use; // true while being committed
+ bool released; // true after buffer_release() was called
};
diff --git a/src/drivers/Wayland/Fl_Wayland_Graphics_Driver.H b/src/drivers/Wayland/Fl_Wayland_Graphics_Driver.H
index 9991bd99f..8dfef0a97 100644
--- a/src/drivers/Wayland/Fl_Wayland_Graphics_Driver.H
+++ b/src/drivers/Wayland/Fl_Wayland_Graphics_Driver.H
@@ -30,20 +30,22 @@
class Fl_Wayland_Graphics_Driver : public Fl_Cairo_Graphics_Driver {
public:
struct draw_buffer {
+ unsigned char *buffer;
+ cairo_t *cairo_;
size_t data_size; // of wl_buffer and buffer
int stride;
int width;
- unsigned char *buffer;
- cairo_t *cairo_;
};
struct wld_buffer {
struct draw_buffer draw_buffer;
+ struct wl_list link; // links all buffers from the same wl_shm_pool
struct wl_buffer *wl_buffer;
void *data;
struct wl_callback *cb;
- bool draw_buffer_needs_commit;
struct wl_shm_pool *shm_pool;
- struct wl_list link; // links all buffers from the same wl_shm_pool
+ bool draw_buffer_needs_commit;
+ bool in_use; // true while being committed
+ bool released; // true after buffer_release() was called
};
struct wld_shm_pool_data { // one record attached to each wl_shm_pool object
char *pool_memory; // start of mmap'ed memory encapsulated by the wl_shm_pool
diff --git a/src/drivers/Wayland/Fl_Wayland_Graphics_Driver.cxx b/src/drivers/Wayland/Fl_Wayland_Graphics_Driver.cxx
index f738a88a5..399388e40 100644
--- a/src/drivers/Wayland/Fl_Wayland_Graphics_Driver.cxx
+++ b/src/drivers/Wayland/Fl_Wayland_Graphics_Driver.cxx
@@ -32,6 +32,23 @@ extern "C" {
static struct wl_shm_pool *pool = NULL; // the current pool
+static void do_buffer_release(struct Fl_Wayland_Graphics_Driver::wld_buffer *);
+
+
+static void buffer_release_listener(void *user_data, struct wl_buffer *wl_buffer)
+{
+ struct Fl_Wayland_Graphics_Driver::wld_buffer *buffer =
+ (struct Fl_Wayland_Graphics_Driver::wld_buffer*)user_data;
+ buffer->in_use = false;
+ if (buffer->released) do_buffer_release(buffer);
+}
+
+
+static const struct wl_buffer_listener buffer_listener = {
+ buffer_release_listener
+};
+
+
struct Fl_Wayland_Graphics_Driver::wld_buffer *
Fl_Wayland_Graphics_Driver::create_shm_buffer(int width, int height)
{
@@ -43,12 +60,18 @@ struct Fl_Wayland_Graphics_Driver::wld_buffer *
struct wld_shm_pool_data *pool_data = pool ? // data record attached to current pool
(struct wld_shm_pool_data *)wl_shm_pool_get_user_data(pool) : NULL;
int pool_size = pool ? pool_data->pool_size : default_pool_size; // current pool size
- if (pool) {
+ if (pool && !wl_list_empty(&pool_data->buffers)) {
// last wld_buffer created from current pool
struct wld_buffer *record = wl_container_of(pool_data->buffers.next, record, link);
chunk_offset = ((char*)record->data - pool_data->pool_memory) + record->draw_buffer.data_size;
}
if (!pool || chunk_offset + size > pool_size) { // if true, a new pool is needed
+ if (pool && wl_list_empty(&pool_data->buffers)) {
+ wl_shm_pool_destroy(pool);
+ /*int err = */munmap(pool_data->pool_memory, pool_data->pool_size);
+// printf("create_shm_buffer munmap(%p)->%d\n", pool_data->pool_memory, err);
+ free(pool_data);
+ }
chunk_offset = 0;
pool_size = default_pool_size;
if (size > pool_size) pool_size = 2 * size; // a larger pool is needed
@@ -66,7 +89,7 @@ struct Fl_Wayland_Graphics_Driver::wld_buffer *
Fl_Wayland_Screen_Driver *scr_driver = (Fl_Wayland_Screen_Driver*)Fl::screen_driver();
pool = wl_shm_create_pool(scr_driver->wl_shm, fd, pool_size);
close(fd); // does not prevent the mmap'ed memory from being used
-//puts("wl_shm_create_pool");
+//printf("wl_shm_create_pool %p size=%d\n",pool_data->pool_memory , pool_size);
pool_data->pool_size = pool_size;
wl_list_init(&pool_data->buffers);
wl_shm_pool_set_user_data(pool, pool_data);
@@ -81,6 +104,7 @@ struct Fl_Wayland_Graphics_Driver::wld_buffer *
buffer->draw_buffer_needs_commit = true;
//fprintf(stderr, "create_shm_buffer: %dx%d = %d\n", width, height, size);
cairo_init(&buffer->draw_buffer, width, height, stride, Fl_Cairo_Graphics_Driver::cairo_format);
+ wl_buffer_add_listener(buffer->wl_buffer, &buffer_listener, buffer);
return buffer;
}
@@ -139,6 +163,7 @@ void Fl_Wayland_Graphics_Driver::buffer_commit(struct wld_window *window,
memcpy(window->buffer->data, window->buffer->draw_buffer.buffer, window->buffer->draw_buffer.data_size);
wl_surface_damage_buffer(window->wl_surface, 0, 0, 1000000, 1000000);
}
+ window->buffer->in_use = true;
wl_surface_attach(window->wl_surface, window->buffer->wl_buffer, 0, 0);
wl_surface_set_buffer_scale(window->wl_surface,
Fl_Wayland_Window_Driver::driver(window->fl_win)->wld_scale());
@@ -174,29 +199,36 @@ void Fl_Wayland_Graphics_Driver::cairo_init(struct Fl_Wayland_Graphics_Driver::d
}
+// runs when buffer->in_use is false and buffer->released is true
+static void do_buffer_release(
+ struct Fl_Wayland_Graphics_Driver::wld_buffer *buffer) {
+ struct wl_shm_pool *my_pool = buffer->shm_pool;
+ struct Fl_Wayland_Graphics_Driver::wld_shm_pool_data *pool_data =
+ (struct Fl_Wayland_Graphics_Driver::wld_shm_pool_data*)
+ wl_shm_pool_get_user_data(my_pool);
+ wl_buffer_destroy(buffer->wl_buffer);
+ // remove wld_buffer from list of pool's buffers
+ wl_list_remove(&buffer->link);
+ free(buffer);
+ if (wl_list_empty(&pool_data->buffers) && my_pool != pool) {
+ // all buffers from pool are gone
+ wl_shm_pool_destroy(my_pool);
+ /*int err = */munmap(pool_data->pool_memory, pool_data->pool_size);
+//printf("do_buffer_release munmap(%p)->%d\n", pool_data->pool_memory, err);
+ free(pool_data);
+ }
+}
+
+
void Fl_Wayland_Graphics_Driver::buffer_release(struct wld_window *window)
{
- if (window->buffer) {
+ if (window->buffer && !window->buffer->released) {
+ window->buffer->released = true;
if (window->buffer->cb) wl_callback_destroy(window->buffer->cb);
- struct wl_shm_pool *my_pool = window->buffer->shm_pool;
- struct wld_shm_pool_data *pool_data =
- (struct wld_shm_pool_data*)wl_shm_pool_get_user_data(my_pool);
- wl_buffer_destroy(window->buffer->wl_buffer);
-//printf("wl_buffer_destroy(%p)\n",window->buffer->wl_buffer);
- // remove wld_buffer from list of pool's buffers
- wl_list_remove(&window->buffer->link);
-//printf("last=%p\n", wl_list_empty(&pool_data->buffers) ? NULL : pool_data->buffers.next);
- if (wl_list_empty(&pool_data->buffers)) { // all buffers from pool are gone
- wl_shm_pool_destroy(my_pool);
- /*int err = */munmap(pool_data->pool_memory, pool_data->pool_size);
-//printf("munmap(%p)->%d\n", pool_data->pool_memory, err);
- free(pool_data);
- if (my_pool == pool) pool = NULL;
- }
delete[] window->buffer->draw_buffer.buffer;
window->buffer->draw_buffer.buffer = NULL;
cairo_destroy(window->buffer->draw_buffer.cairo_);
- free(window->buffer);
+ if (!window->buffer->in_use) do_buffer_release(window->buffer);
window->buffer = NULL;
}
}
--
cgit v1.2.3