From 92f6962b597316ab0e05a6b7aeaabd7b492af602 Mon Sep 17 00:00:00 2001 From: ManoloFLTK <41016272+ManoloFLTK@users.noreply.github.com> Date: Tue, 9 Aug 2022 17:43:48 +0200 Subject: Fix Fl_Xlib_Graphics_Driver for tiled-depth 3 images. Modifying test/tiled_image to make it use a depth-3 image for tiling (rather than an Fl_Pixmap) shows the filter does require to use PictOpOver as the render op in the XRenderComposite call. --- src/drivers/Xlib/Fl_Xlib_Graphics_Driver_image.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/drivers/Xlib/Fl_Xlib_Graphics_Driver_image.cxx b/src/drivers/Xlib/Fl_Xlib_Graphics_Driver_image.cxx index dd9b7135e..73bea246e 100644 --- a/src/drivers/Xlib/Fl_Xlib_Graphics_Driver_image.cxx +++ b/src/drivers/Xlib/Fl_Xlib_Graphics_Driver_image.cxx @@ -836,8 +836,8 @@ int Fl_Xlib_Graphics_Driver::scale_and_render_pixmap(Fl_Offscreen pixmap, int de // "When you use a filter you'll probably want to use PictOpOver as the render op, // regardless of whether the source picture has an alpha channel or not, since // the edges may end up having alpha values after the filter has been applied." - // suggests this would be preferable : - // has_alpha = true; + // suggests this is necessary : + has_alpha = true; } } XRenderComposite(fl_display, (has_alpha ? PictOpOver : PictOpSrc), src, None, dst, 0, 0, 0, 0, -- cgit v1.2.3