OS X Quartz rendering: text is now clipped and drawn in the correct color. I had to reverse the 'selection color' change because some widgets rely on this color being dark. Still problems with Fluid rendering and measuring fonts before a window is open.

git-svn-id: file:///fltk/svn/fltk/branches/branch-1.1@5174 ea41ed52-d2ee-0310-a9c1-e6b18d33e121

3 files changed, 49 insertions, 16 deletions

diff --git a/src/Fl_get_system_colors.cxx b/src/Fl_get_system_colors.cxx
index 24fae8714..0b630703c 100644
--- a/src/Fl_get_system_colors.cxx
+++ b/src/Fl_get_system_colors.cxx
@@ -165,17 +165,24 @@ void Fl::get_system_colors()
 {
   fl_open_display();
 
-  OSStatus err;
   if (!fl_bg2_set) background2(0xff, 0xff, 0xff);
   if (!fl_fg_set) foreground(0, 0, 0);
   if (!fl_bg_set) background(0xd8, 0xd8, 0xd8);
-
+  
+#if 0 
+  // this would be the correct code, but it does not run on all versions
+  // of OS X. Also, setting a bright selection color would require 
+  // some updates in Fl_Adjuster and Fl_Help_Browser
+  OSStatus err;
   RGBColor c;
   err = GetThemeBrushAsColor(kThemeBrushPrimaryHighlightColor, 24, true, &c);
   if (err)
     set_selection_color(0x00, 0x00, 0x80);
   else
     set_selection_color(c.red, c.green, c.blue);
+#else
+  set_selection_color(0x00, 0x00, 0x80);
+#endif
 }
 #else
 
diff --git a/src/Fl_mac.cxx b/src/Fl_mac.cxx
index 5a7db50ac..c7a03531a 100644
--- a/src/Fl_mac.cxx
+++ b/src/Fl_mac.cxx
@@ -2085,7 +2085,7 @@ extern class Fl_FontSize *fl_fontsize;
 extern void fl_font(class Fl_FontSize*);
 extern void fl_quartz_restore_line_style_();
 
-// FLTK has only on global graphics state. This function copies the FLTK state into the
+// FLTK has only one global graphics state. This function copies the FLTK state into the
 // current Quartz context
 void Fl_X::q_fill_context() {
   if (!fl_gc) return;
@@ -2099,14 +2099,12 @@ void Fl_X::q_fill_context() {
   }
   CGContextTranslateCTM(fl_gc, 0.5, hgt-0.5f);
   CGContextScaleCTM(fl_gc, 1.0f, -1.0f);
-  static CGAffineTransform font_mx = { 1, 0, 0, -1, 0, 0 };
-  CGContextSetTextMatrix(fl_gc, font_mx);
   fl_font(fl_fontsize);
   fl_color(fl_color_);
   fl_quartz_restore_line_style_();
 }
 
-// The only way to reste clipping to its original state is to pop the current graphics
+// The only way to reset clipping to its original state is to pop the current graphics
 // state and restore the global state.
 void Fl_X::q_clear_clipping() {
   if (!fl_gc) return;
diff --git a/src/fl_font_mac.cxx b/src/fl_font_mac.cxx
index b35aaebdb..c714dc826 100644
--- a/src/fl_font_mac.cxx
+++ b/src/fl_font_mac.cxx
@@ -79,13 +79,16 @@ Fl_FontSize::Fl_FontSize(const char* name, int Size) {
   err = ATSUSetTextPointerLocation(layout, mTxt, kATSUFromTextBeginning, 1, 1);
   err = ATSUCreateStyle(&style);
   err = ATSUSetRunStyle(layout, style, kATSUFromTextBeginning, kATSUToTextEnd);
-    // now set the actual font, size and attributes
+    // now set the actual font, size and attributes. We also set the font matrix to 
+    // render our font up-side-down, so when rendered through our inverted CGContext,
+    // text will appear normal again.
   Fixed fsize = IntToFixed(Size);
   ATSUFontID fontID = FMGetFontFromATSFontRef(font);
-  ATSUAttributeTag sTag[] = { kATSUFontTag, kATSUSizeTag };
-  ByteCount sBytes[] = { sizeof(ATSUFontID), sizeof(Fixed) };
-  ATSUAttributeValuePtr sAttr[] = { &fontID, &fsize };
-  err = ATSUSetAttributes(style, 2, sTag, sBytes, sAttr);
+  static CGAffineTransform font_mx = { 1, 0, 0, -1, 0, 0 };
+  ATSUAttributeTag sTag[] = { kATSUFontTag, kATSUSizeTag, kATSUFontMatrixTag };
+  ByteCount sBytes[] = { sizeof(ATSUFontID), sizeof(Fixed), sizeof(CGAffineTransform) };
+  ATSUAttributeValuePtr sAttr[] = { &fontID, &fsize, &font_mx };
+  err = ATSUSetAttributes(style, 3, sTag, sBytes, sAttr);
     // next, make sure that Quartz will only render at integer coordinates
   ATSLineLayoutOptions llo = kATSLineUseDeviceMetrics|kATSLineDisableAllLayoutOperations;
   ATSUAttributeTag aTag[] = { kATSULineLayoutOptionsTag };
@@ -95,9 +98,20 @@ Fl_FontSize::Fl_FontSize(const char* name, int Size) {
     // now we are finally ready to measure some letter to get the bounding box
   Fixed bBefore, bAfter, bAscent, bDescent;
   err = ATSUGetUnjustifiedBounds(layout, kATSUFromTextBeginning, 1, &bBefore, &bAfter, &bAscent, &bDescent);
-  ascent = FixedToInt(bAscent);
-  descent = FixedToInt(bDescent);
-  q_width = FixedToInt(bAfter);
+    // Requesting a certain height font on Mac does not guarantee that ascent+descent
+    // equal the requested height. I consider requesting noew fonts until that is the
+    // case, but for now we simply make sure that our store ascent and descent add up 
+    // as expected.
+    // The font "Apple Chancery" is a pretty extreme example of overlapping letters.
+  float fa = -FixedToFloat(bAscent), fd = -FixedToFloat(bDescent);
+  if (fa>0.0f && fd>0.0f) {
+    float f = Size/(fa+fd);
+    ascent = int(fa*f+0.5f);
+    descent = Size - ascent;
+  }
+  int w = FixedToInt(bAfter);
+  if (w)  
+    q_width = FixedToInt(bAfter);
 #endif
 }
 
@@ -188,7 +202,7 @@ static UniChar *utf16buf = 0;
 static int utf16len = 0;
 UniChar *fl_macToUtf16(const char *txt, int len)
 {
-  if (len>utf16len) {
+  if ((len+1)>utf16len) {
     utf16len = len+100;
     free(utf16buf);
     utf16buf = (UniChar*)malloc((utf16len+1)*sizeof(UniChar));
@@ -273,7 +287,10 @@ double fl_width(const char* txt, int n) {
   if (!fl_gc) {
     Fl_Window *w = Fl::first_window();
     if (w) w->make_current();
-    if (!fl_gc) return -1;
+    if (!fl_gc) {
+      fprintf(stderr, "FLTK:fl_width() - no visible window to measure this text.\n");
+      return -1;
+    }
   }
   OSStatus err;
     // convert to UTF-16 first
@@ -281,6 +298,11 @@ double fl_width(const char* txt, int n) {
     // now collect our ATSU resources
   ATSUTextLayout layout = fl_fontsize->layout;
   err = ATSUSetTextPointerLocation(layout, uniStr, kATSUFromTextBeginning, n, n);
+    // activate the current GC
+  ByteCount iSize = sizeof(CGContextRef);
+  ATSUAttributeTag iTag = kATSUCGContextTag;
+  ATSUAttributeValuePtr iValuePtr=&fl_gc;
+  ATSUSetLayoutControls(layout, 1, &iTag, &iSize, &iValuePtr);
     // now measure the bounding box
   Fixed bBefore, bAfter, bAscent, bDescent;
   err = ATSUGetUnjustifiedBounds(layout, kATSUFromTextBeginning, n, &bBefore, &bAfter, &bAscent, &bDescent);
@@ -314,6 +336,12 @@ void fl_draw(const char *str, int n, float x, float y) {
   UniChar *uniStr = fl_macToUtf16(str, n);
     // now collect our ATSU resources
   ATSUTextLayout layout = fl_fontsize->layout;
+
+  ByteCount iSize = sizeof(CGContextRef);
+  ATSUAttributeTag iTag = kATSUCGContextTag;
+  ATSUAttributeValuePtr iValuePtr=&fl_gc;
+  ATSUSetLayoutControls(layout, 1, &iTag, &iSize, &iValuePtr);
+
   err = ATSUSetTextPointerLocation(layout, uniStr, kATSUFromTextBeginning, n, n);
   err = ATSUDrawText(layout, kATSUFromTextBeginning, n, FloatToFixed(x), FloatToFixed(y));
 #else